New ImGui IO event API #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| if (MouseIndex < Utilities::GetArraySize(MouseButtonsDown)) | ||
| const ImGuiKey& ImKey = ImGuiInterops::UnrealToImGuiKey(Key); | ||
| IO.AddKeyEvent(ImKey, bIsDown); |
There was a problem hiding this comment.
The UnrealToImGuiKey has ImGuiKey_LeftShift, ImGuiKey_RightShift, ImGuiKey_LeftControl, ImGuiKey_RightControl, ImGuiKey_LeftAlt, ImGuiKey_RightAlt, ImGuiKey_LeftSuper and ImGuiKey_RightSuper But we also need to pass events for ImGuiKey_ModShift, ImGuiKey_ModControl, ImGuiKey_ModAlt and ImGuiKey_ModSuper.
Maybe you can have a UnrealToImGuiModKeyMap map UnrealToImGuiKeyMap just like as:
{
EKeys::LeftShift : ImGuiKey_ModShift,
EKeys::RigthShift : ImGuiKey_ModShift,
EKeys::LeftControl : ImGuiKey_ModCtrl,
EKeys::RightControl : ImGuiKey_ModCtrl,
EKeys::LeftAlt : ImGuiKey_ModAlt,
EKeys::RightAlt : ImGuiKey_ModAlt,
EKeys::LeftCommand : ImGuiKey_ModSuper,
EKeys::RightCommand : ImGuiKey_ModSuper,
}
And then:
if(ImGuiInterops::UnrealToImGuiModKey(Key) != ImGuiKey_None)
{
// Will need UnrealToImGuiModKey function just like UnrealToImGuiKey, maybe without the log
IO.AddKeyEvent(ImGuiInterops::UnrealToImGuiModKey(Key), bIsDown);
}
There was a problem hiding this comment.
Without these anything that uses Mod keys break with this PR change
|
Is this properly tested? I gave it a try but keyboard & gamepad navigations both not working anymore after applying the diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reworks the Unreal backend for ImGui to use the new IO event API introduced in ImGui 1.87.
Most of the intermediate storage has been removed in this project as core ImGui now handles it correctly even at low framerates. Certain missing keybinds have been added (such as Super/Command).
It is advisable for users of this project to thoroughly review and test this before it is merged.